GH-3120 Align KafkaListenerContainerCustomizer with DLQ customizer de…#3210
Open
wadhwaroh-lang wants to merge 2 commits into
Open
GH-3120 Align KafkaListenerContainerCustomizer with DLQ customizer de…#3210wadhwaroh-lang wants to merge 2 commits into
wadhwaroh-lang wants to merge 2 commits into
Conversation
…ustomizer defaults Make the three-argument configure() a no-op default and keep the four-argument method abstract so the interface can be implemented as a lambda that receives ExtendedConsumerProperties, matching ListenerContainerWithDlqAndRetryCustomizer. Signed-off-by: wadhwaroh-lang <wadhwa.roh@gmail.com>
Apache's Maven CDN no longer hosts 3.8.9, so jvalkeal/setup-maven fails before tests run. Point the workflow at the currently published 3.9.16. Signed-off-by: wadhwaroh-lang <wadhwa.roh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KafkaListenerContainerCustomizerwithListenerContainerWithDlqAndRetryCustomizerby making the 3-argconfigure()a no-op default and keeping the 4-arg method abstractExtendedConsumerPropertiesFixes #3120
Test plan
./mvnw -pl binders/kafka-binder/spring-cloud-stream-binder-kafka -am test -Dtest=KafkaListenerContainerCustomizerTests -Dsurefire.failIfNoSpecifiedTests=false