Prevent Micrometer global registry from pinning application contexts#50886
Open
LordKay-sudo wants to merge 1 commit into
Open
Prevent Micrometer global registry from pinning application contexts#50886LordKay-sudo wants to merge 1 commit into
LordKay-sudo wants to merge 1 commit into
Conversation
Track meter registries added to Metrics.globalRegistry and remove them on context close. Disable use of the global registry in tests by default to avoid pinning cached test contexts. Signed-off-by: LordKay-sudo <lkandiro@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to spring-framework#36737.
MeterRegistryCloserso it tracks registries added toMetrics.globalRegistryat registration time instead of snapshottingMeterRegistrybeans in its constructor (which often runs before registries exist).ContextClosedEvent, remove tracked registries from the global registry and close them.DisableGlobalMeterRegistryContextCustomizerFactoryso tests defaultmanagement.metrics.use-global-registry=falsewhen not explicitly configured, mirroring the existing Reactor global-resources customizer and preventing cached test contexts from being pinned via Micrometer.Test plan
./gradlew :module:spring-boot-micrometer-metrics:test --tests MeterRegistryPostProcessorTests./gradlew :core:spring-boot-test:test --tests DisableGlobalMeterRegistryContextCustomizerFactoryTests