Refactor to instanceof pattern variable#2017
Open
arefbehboudi wants to merge 2 commits intospring-projects:mainfrom
Open
Refactor to instanceof pattern variable#2017arefbehboudi wants to merge 2 commits intospring-projects:mainfrom
arefbehboudi wants to merge 2 commits intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
|
Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. Also - |
Author
|
But how can I change the commit message after the push? |
Contributor
|
git commit --amend and then git push -f ... |
Author
|
Thank you! |
The constructor for DefaultTransaction now requires a name and `nested` flag. Closes spring-projects#2016 Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
Closes spring-projects#2018 Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some of our cases, we are currently using the traditional instanceof checks followed by explicit type casting. With the introduction of Pattern Matching in recent Java versions, we can refactor these checks to make the code more concise and readable.