Closed
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Pankraz76
force-pushed
the
fix-ignored-exceptions
branch
from
1e3ec20 to
8eacca1
Compare
Pankraz76
commented
Jun 13, 2025
| out.flush(); | ||
| // need to str | ||
| } | ||
| catch (NullPointerException ex) { |
Author
There was a problem hiding this comment.
thats why its important to have empty blocks inline.
Author
There was a problem hiding this comment.
as this so important should give this special attention then. @bclozel
its not about the close as thats the same but about the catch as this seems to differ.
Pankraz76
force-pushed
the
fix-ignored-exceptions
branch
from
3c9ff87 to
333af51
Compare
Pankraz76
force-pushed
the
fix-ignored-exceptions
branch
from
333af51 to
d5ceb68
Compare
Signed-off-by: Vincent Potucek <vpotucek@me.com>
Pankraz76
force-pushed
the
fix-ignored-exceptions
branch
from
d5ceb68 to
e6c4c5f
Compare
bclozel
added
type: task
bclozel
pushed a commit
that referenced
this pull request
Jun 15, 2025
The Spring codebase sometimes ignores exceptions in catch blocks on purpose. This is often called out by an inline comment. We should make this more obvious by renaming the exception argument in the catch block to declare whether the exception is "ignored" or "expected". See gh-35047 Signed-off-by: Vincent Potucek <vpotucek@me.com> [brian.clozel@broadcom.com: rework commit message] Signed-off-by: Brian Clozel <brian.clozel@broadcom.com>
Author
|
thanks |
Member
|
Thanks for your contribution @Pankraz76 |
This was referenced Jun 15, 2025
izeye
added a commit
to izeye/spring-framework
that referenced
this pull request
Jun 22, 2025
See spring-projectsgh-35047 Signed-off-by: Johnny Lim <izeye@naver.com>
izeye
added a commit
to izeye/spring-framework
that referenced
this pull request
Jun 22, 2025
This commit also changes to use "ignored" for exception variable names instead of "ignore". See spring-projectsgh-35047 Signed-off-by: Johnny Lim <izeye@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid round abound and just name it ignored like commonly suggested by static code analysis PMD and IDEA.
its already the pattern so just complain: