Expose ClassLoader from DefaultDeserializer#36833
Open
seonwoo-jung wants to merge 1 commit into
Open
Conversation
Add a public accessor for the ClassLoader configured on a DefaultDeserializer instance so that callers no longer need to read the private field via reflection in order to forward it to a ConfigurableObjectInputStream subclass. Closes spring-projectsgh-36827 Signed-off-by: seonwoo_jung <laborlawseon@kap.kr>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a public
getClassLoader()accessor onDefaultDeserializerto expose theClassLoaderconfigured via theconstructor introduced in 4.2.1.
The motivation for this is described in gh-36827: Spring Integration's
AllowListDeserializingConvertercurrently reads the privateclassLoaderfield viaDirectFieldAccessorreflection in order toforward it to a
ConfigurableObjectInputStreamsubclass. Exposing aproper getter avoids the reflection and removes the need for any
related native image hint.
The accessor mirrors the nullability of the underlying field. A pair of
unit tests in
SerializerTestscover both the no-arg and explicitClassLoaderconstructors.Closes gh-36827