Preserve bracketed YAML map keys#37032
Open
Develop-KIM wants to merge 1 commit into
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: Develop-KIM <kimdonghwan913@gmail.com>
Develop-KIM
force-pushed
the
fix-yaml-bracketed-map-keys
branch
from
f3cb513 to
1ca65c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-27020
This preserves YAML map keys that already start with
[by flattening them as literal map keys instead of treating them like collection indexes.Verification:
./gradlew :spring-beans:test --tests org.springframework.beans.factory.config.YamlPropertiesFactoryBeanTests.loadNestedMapWithBracketedKey./gradlew :spring-beans:test --tests org.springframework.beans.factory.config.YamlPropertiesFactoryBeanTests./gradlew :spring-beans:test --tests org.springframework.beans.factory.config.YamlProcessorTests