Conversation
|
Variable needs to be named "pip" or "package" everywhere. Should be consistent between check and installer. |
|
Reason this can't use auto api? |
I followed Some installers use
I followed |
Does method="def #{method_name}(*names, &block)
install #{class_name}.new(self, *names, &block)
end"It seems that a lot of package installers do not support |
Some installers are in different states than others, they probably all should properly support sudo.
Do you have an idea of how? The problem is when you use *array that then taking other arguments becomes problematic. This installer doesn't currently use options in any case so it seems like auto-api could be used as-is. |
lib/sprinkle/installers/pip.rb
Outdated
|
|
||
| verify_api do | ||
| def has_pip(package) | ||
| @commands << "pip show #{package} | fgrep Name" |
There was a problem hiding this comment.
Prefer grep -F and lets match 'Name:' with the colon to be clearer.
There was a problem hiding this comment.
New commits pushed uses grep -F instead of fgrep,
with comments on matching pattern.
Also replace `fgrep` and `grep -F`.
No description provided.