Add sudo support for npm installer.#216
Add sudo support for npm installer.#216weakish wants to merge 4 commits intosprinkle-tool:masterfrom
sudo support for npm installer.#216Conversation
`fgrep` is faster than `grep`.
|
What is fgrep? This has to work on a ton of diff platforms. OS X, other BSDs, Linux and its proliferation of distros. Unless there is a big reason to change grep is probably safer, no? |
Same as
Since Anywhere, |
`fgrep` is deprecated according to `man grep`.
lib/sprinkle/installers/npm.rb
Outdated
| verify_api do | ||
| def has_npm(package) | ||
| @commands << "npm --global list | grep \"#{package}@\"" | ||
| @commands << "npm --global list | grep -F \"#{package}@\"" |
There was a problem hiding this comment.
I think to be correct her we need to match " [package]" (space in front), based on the output - to avoid false matches, yes? I'd say fix this and we can merge.
No description provided.