Don't build demo on publish#7
Merged
Merged
Conversation
Run :signaturepad:publishToMavenCentral instead of the unqualified task so the demo modules are never configured or built during publish. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
addPoint now ignores points outside the pad bounds, which default to 0x0. Give the state a size before gesturing so the test points fall within bounds and strokes are actually recorded. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Runs :signaturepad:allTests (JVM, JS, WasmJS, iOS simulator) on pull requests and pushes to master. Uses macos-latest so the iOS simulator tests can run; scoped to the library so the demo modules aren't built. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Kotlin/Native compiler cache holds Compose ui-uikit objects that hard-reference newer UIKit symbols (e.g. UIViewLayoutRegion), which fail to link against the deployment target and break linkDebugTestIosSimulatorArm64 in CI. Disable the cache for the native targets so those symbols resolve correctly. Uses the disableNativeCache DSL (Kotlin 2.3.20+) rather than the deprecated kotlin.native.cacheKind gradle property. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sproctor
force-pushed
the
fix/dont-build-demo-on-publish
branch
from
0807012 to
d5c1488
Compare
kotlin-js-store/yarn.lock resolves to slightly different contents across platforms (CI macOS vs a Linux dev machine), so kotlinStoreYarnLock fails CI on a platform-driven diff. Set yarnLockMismatchReport to WARNING so the lock is still tracked but doesn't break the build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also, add CI tests and fix test failures