Simplify Docker tag publishing workflow#1333
Conversation
a04d296 to
07fb509
Compare
07fb509 to
30cd940
Compare
30cd940 to
3cb46d5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cb46d5455
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: | | ||
| docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \ | ||
| $(printf '${{ env.REGISTRY_IMAGE }}@sha256:%s ' *) | ||
| tags=(-t "${REGISTRY_IMAGE}:${GITHUB_REF_NAME}${TAG_SUFFIX}") |
There was a problem hiding this comment.
Sanitize the ref before using it as a Docker tag
When a valid release tag matching the workflow's v* filter contains Docker-invalid characters, such as the valid SemVer tag v1.2.3+build.1, this constructs an invalid image reference and docker buildx imagetools create fails, preventing the version and latest manifests from being published. The removed docker/metadata-action automatically replaced invalid tag-character sequences with - as documented in its tag sanitization behavior, so preserve equivalent sanitization before constructing these tags.
Useful? React with 👍 / 👎.
Summary
Complexity diagnosis
lateston release tags.Validation
git diff --check -- .github/workflows/ci.ymlactionlint .github/workflows/ci.yml