[DNR WIP] Prototype: UIKit bridging with simplified ViewEnvironmentUI#204
Draft
[DNR WIP] Prototype: UIKit bridging with simplified ViewEnvironmentUI#204
Conversation
n8chur
force-pushed
the
westin/ios/view-environment-unitification-simplfified
branch
from
e83fe25 to
ef80997
Compare
n8chur
commented
May 11, 2023
Comment on lines
+4
to
+5
|
|
||
| > **_Note:_** This is currently considered an implementation detail of `MarketUI` and is intended to bridge `MarketContext` propagation between `MarketUI` and the Modals framework. Use the wrapper types declared in `MarketUI` to access the propagation of Market features. |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| > **_Note:_** This is currently considered an implementation detail of `MarketUI` and is intended to bridge `MarketContext` propagation between `MarketUI` and the Modals framework. Use the wrapper types declared in `MarketUI` to access the propagation of Market features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated PRs
https://github.com/squareup/market/pull/6039
https://github.com/squareup/ios-register/pull/84053
Proposal
Proposal: WorkflowUI ViewEnvironment Propagation in UIKit