Add AnyWorkflow(rendering:) to make a constant-rendering workflow#56
Open
bencochran wants to merge 1 commit intomainfrom
Open
Add AnyWorkflow(rendering:) to make a constant-rendering workflow#56bencochran wants to merge 1 commit intomainfrom
AnyWorkflow(rendering:) to make a constant-rendering workflow#56bencochran wants to merge 1 commit intomainfrom
Conversation
bencochran
requested review from
AquaGeek,
JustinDSN,
dhavalshreyas and
zach-klippenstein
| /// Creates an AnyWorkflow that does nothing but echo the given `rendering`. | ||
| /// | ||
| /// - Note: To use with `RenderTester`, use `expectRenderingWorkflow` | ||
| public init(rendering: Rendering) { |
Contributor
There was a problem hiding this comment.
I wonder if this extension adds a lot of value. Simple enough to use RenderingWorkflow as-is, and we won't need any other expect...() method.
zach-klippenstein
approved these changes
Dec 9, 2020
Collaborator
zach-klippenstein
left a comment
zach-klippenstein
left a comment
There was a problem hiding this comment.
We have a Workflow.rendering(r: R): Workflow<Unit, Nothing, R> function that does something very similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin has
Workflow.rendering(). Seems like a handy convenience for fakes and testing (and dependency injection where you support dynamic content but some consumers just want static renderings).Checklist
UI TestsSnapshot Tests (iOS only)