Skip to content

Polish SQUID_CHECK_KRB5_CONTEXT_MEMORY_CACHE macro #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yadij wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Polish SQUID_CHECK_KRB5_CONTEXT_MEMORY_CACHE macro #2316

yadij wants to merge 8 commits into from

Conversation

@yadij
Copy link
Contributor

@yadij yadij commented Dec 10, 2025

  • trivial whitespace cleanup
  • reposition for alphabetical naming order
  • move SQUID_DEFINE_BOOL inside the check macro

@yadij
Copy link
Contributor Author

yadij commented Dec 10, 2025

FTR; these changes have already passed review in PR #1157.

@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) backport-to-v7 maintainer has approved these changes for v7 backporting labels Dec 10, 2025
@yadij
Copy link
Contributor Author

yadij commented Dec 21, 2025

These changes have reached 10+ days without any negative feedback. The merge bot should have committed them already.

@rousskov rousskov mentioned this pull request Dec 21, 2025
Open
rousskov
rousskov previously requested changes Dec 21, 2025
View reviewed changes
@rousskov rousskov removed M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Dec 21, 2025
@yadij yadij requested a review from rousskov December 23, 2025 21:57
@yadij yadij added the S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box label Dec 23, 2025
kinkie
kinkie previously approved these changes Dec 25, 2025
View reviewed changes
@yadij
Copy link
Contributor Author

yadij commented Dec 30, 2025

Blocked for 3 weeks by @rousskov because lines of text unrelated to this PR exist in the Squid code.

@kinkie
Copy link
Contributor

kinkie commented Dec 30, 2025

Blocked for 3 weeks by @rousskov because lines of text unrelated to this PR exist in the Squid code.

The comment has been resolved, the related change merged. @rousskov can this go in now?

@rousskov
Copy link
Contributor

rousskov commented Dec 30, 2025

Blocked for 3 weeks by @rousskov because lines of text unrelated to this PR exist in the Squid code.

The above assertion is false.

@rousskov rousskov dismissed their stale review December 30, 2025 21:17

My concern has been addressed.

@rousskov rousskov removed their request for review December 30, 2025 21:17
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Dec 30, 2025
squid-anubis pushed a commit that referenced this pull request Dec 30, 2025
@yadij @squid-anubis
Polish SQUID_CHECK_KRB5_CONTEXT_MEMORY_CACHE macro (#2316)
58539d3 
* trivial whitespace cleanup
* reposition for alphabetical naming order
* move SQUID_DEFINE_BOOL inside the check macro
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-abandoned-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Dec 30, 2025
squid-anubis pushed a commit that referenced this pull request Dec 31, 2025
@yadij @squid-anubis
Polish SQUID_CHECK_KRB5_CONTEXT_MEMORY_CACHE macro (#2316)
9553723 
* trivial whitespace cleanup
* reposition for alphabetical naming order
* move SQUID_DEFINE_BOOL inside the check macro
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-abandoned-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinkie kinkie kinkie approved these changes

@rousskov rousskov rousskov left review comments

Assignees

No one assigned

Labels

backport-to-v7 maintainer has approved these changes for v7 backporting M-passed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels S-waiting-for-author author action is expected (and usually required)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yadij @kinkie @rousskov @squid-anubis