Polish SQUID_AUTO_LIB and SQUID_OPTIONAL_LIB macros

[yadij]

Generate the third parameter value from the first.
Remove from all callers.

[yadij]

This PR has passed the 10+ days without veto criteria for merge. Current state is +1 vote for merge, no objections.
The mergebot should have started the process already.

@rousskov abusing the github interface "requested review" flags to indefinitely stall progress.

[rousskov]

@rousskov abusing the github interface "requested review" flags to indefinitely stall progress.

I am correctly using GitHub review requests to flag PRs that I should review. My reviews often discover bugs, as was the case with this PR. Accusing me of indefinitely stalling progress is both factually wrong and utterly unfair. I continue to beg you to stop posting new pull requests and start cooperating towards merging my PRs (that you are stalling) along with the backlog that have been created by stalling some of those PRs.

[yadij]

After fixing all of this, please test by comparing generated configure files (at least). Please also post diff --ignore-blank-lines -u configure-before configure-after output and explain any exposed non-obvious changes that are not already covered by PR description.

As requested.

@@ -2056,11 +2056,12 @@
                           support), XBS5_LP64_OFF64 (legacy, 64 bits),
                           XBS5_LPBIG_OFFBIG (legacy, large pointers and files)
                           or default (The default for your OS)
-  --without-pam           Compile without the Pluggable Authentication Modules
-                          library.
+  --without-pam           Compile without the Pluggable Authentication
+                          Modules library.
   --without-tdb           Compile without the Samba TrivialDB library.
   --with-valgrind-debug   Include debug instrumentation for use with valgrind
-  --without-cppunit       Compile without the cppunit test framework library.
+  --without-cppunit       Compile without the cppunit test framework
+                          library.
   --without-cap           Compile without the Linux capabilities library.
 
   --with-filedescriptors=NUMBER

... not sure what is causing this. I suspect the help text was already borderline for line-wrapping and the change in length from using absolute-string to an M4 variable (OPTIONTXT) causes it to push over/under the boundary.

@@ -31643,7 +31680,12 @@
 
 fi
 
-  if test "x$withval" = "x"
+
+
+
+
+
+  if test "x$with_openssl" = "x"
 then :
   with_openssl=no
 fi

... intentional bug fix from use of RESULT variable at acinclude/squid-util.m4 line 277.
Bug was that withval is the variable which may still contain garbage or path.

@@ -34267,15 +34316,15 @@
       with_mit_krb5=yes
       if test -d "$withval/lib64"
 then :
-  LIB_KRB5_PATH+="-L$withval/lib64"
+  LIBMIT_KRB5_PATH+="-L$withval/lib64"
 fi
       if test -d "$withval/lib"
 then :
-  LIB_KRB5_PATH+="-L$withval/lib"
+  LIBMIT_KRB5_PATH+="-L$withval/lib"
 fi
       if test -d "$withval/include"
 then :
-  LIB_KRB5_CFLAGS+="-I$withval/include"
+  LIBMIT_KRB5_CFLAGS+="-I$withval/include"
 fi
      ;;
 esac

... intentional bug fix from no longer passing in wrong variable name at configure.ac line 1140.
Bug was of course that the wrong-named variables are never used, and the used variables not set properly.

[rousskov]

@@ -31643,7 +31680,12 @@
 
 fi
 
-  if test "x$withval" = "x"
+
+
+
+
+
+  if test "x$with_openssl" = "x"
 then :
   with_openssl=no
 fi

... intentional bug fix from use of RESULT variable at acinclude/squid-util.m4 line 277. Bug was that withval is the variable which may still contain garbage or path.

Please fix PR description to disclose this bug fix and, more importantly, its effects on admins.

Same for the LIB_KRB5_CFLAGS fix.

If both macros were buggy, then PR title should start with "Fix" rather than "Polish". If only one macro was buggy, then I recommend focusing on that macro in "Fix SQUID_... macro" PR title and mentioning the other one in PR description.