Repository navigation
Stop one offline host from failing the link check - #1
Merged
Merged
Conversation
Every CI run since 5 October failed on a single link: the Hinode XRT flare catalogue on the Resources page. The URL is correct and still canonical — the host, xrt.cfa.harvard.edu, stopped answering on both ports while the rest of cfa.harvard.edu stayed up. 846 of 847 links passed with no errors; the failure was one timeout. A timeout is not evidence of a dead link, so lychee now accepts them. A 404, a DNS failure or a TLS error still fails the build, and timeouts still show in the job summary, so a host that never comes back stays visible. That also retires an older workaround. gong.nso.edu, jsoc.stanford.edu and sidc.be were excluded outright because they time out from GitHub's runners, which left those URLs unchecked. They are back under the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has failed on every run since 5 October, always on the same single link: the Hinode XRT flare catalogue (
https://xrt.cfa.harvard.edu/flare_catalog/) on the Resources page. 846 of 847 links passed, zero errors, one timeout.The link is correct and still canonical. The host is offline: no answer on port 443 or 80, while
www.cfa.harvard.eduresponds normally.Change (
lychee.tomlonly):accept_timeouts = true: a timeout no longer fails the build. 404s, DNS and TLS failures still do, and timeouts are still listed in the job summary.gong.nso.edu,jsoc.stanford.eduandsidc.beexcludes, which existed only because those hosts time out from runners. They're checked again.This PR's own CI run is the test: it runs the link check on GitHub's runners with the new config.