refactor(theme): color definitions to use vim.g directly#143
refactor(theme): color definitions to use vim.g directly#143MindTooth merged 1 commit intosrcery-colors:masterfrom
Conversation
|
Hi there, thanks for opening a PR, this looks good, no need to call |
|
If this speeds up, I am all in. is this something that we can extend to more languages? Don’t have to do that now |
|
there are no other |
|
Whats going on with the linter check here? Seems it never runs on external PRs like this, is it suppose to? Should I just bypass it? |
|
I will check pipeline tonight. Maybe |
|
here's what I did to fix the lint job on |
|
I just merged it should be good. Thanks! ❤️ |
These plugins haven't worked in this branch for a while, the old memoize groups are no more. Fix some atrocious formatting as well in the airline theme, think this one's been through a few formatters. Note: lastest master contained fixes for lualine which I resolved here Refs: #143
Changes
Performance: Replaced vim.api.nvim_eval calls with vim.g for faster and more idiomatic access to global variables.
Robustness: Added fallback logic for specific Srcery colors (orange, hardblack, etc.) to ensure the theme doesn't break if certain globals are missing.
Code Quality: Cleaned up redundant section definitions by using local variables (DRY principle).
Formatting: Followed the project's comment style and structure.