fix: stale unlicensed key in deny.toml and rgbuilder LFS path in .gitattributes - #89
Open
nerdalytics wants to merge 1 commit into
Open
nerdalytics wants to merge 1 commit into
nerdalytics wants to merge 1 commit into
Conversation
cargo-deny 0.20.2 removed the `unlicensed` key (EmbarkStudios/cargo-deny#611), so `cargo deny check` aborts on config validation before it inspects anything. The `allow` list already denies a crate whose license cannot be determined. .gitattributes still names `crates/rgbuilder-analysis`, a path that no longer exists after the rgbuilder to rgctl rename, so `git check-attr filter` reports `unspecified` for the real asset. Signed-off-by: nerdalytics <97166791+nerdalytics@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cargo deny checkfails on every run, and the Git LFS filter never applies to the ONNX weight file. One reference is out of date with cargo-deny, the other with the rgbuilder to rgctl rename.Type of Change
Changes Made
deny.toml. cargo-deny 0.20.2 removed the
unlicensedkey in EmbarkStudios/cargo-deny#611, so validation fails before cargo-deny reads any crate. That same PR madedenythe new default for an unlicensed crate, so removing the line changes nothing about the outcome..gitattributes. The LFS pattern still names
crates/rgbuilder-analysis, which the rename to rgctl removed, sogit check-attr filterreturnsunspecifiedfor the real asset. The committed pointer still resolves because git-lfs reads blobs directly, but the next write to that file would commit 205.75 MiB of raw weights, over GitHub's 100 MB limit.Testing
Neither file is Rust, so there is nothing here for
cargo testor clippy to cover. I checked both fixes by hand:cargo deny checkmoved fromerror[deprecated] ... failed to validate configuration fileatdeny.toml:17to reaching the crates.io index fetch. I could not finish the run, because my network blocks crates.io.git check-attr filter -- crates/rgctl-analysis/assets/code-daemon-embed-v1/model.onnx.datamoved fromunspecifiedtolfs.Unit tests added/updated
Integration tests added/updated
Tested with
cargo testManual testing performed
Test environment:
Checklist
Breaking Changes
None. No workflow under
.github/workflows/calls cargo-deny today, so CI behavior does not change, and the.gitattributesfix rewrites no committed blob.Additional Notes
I found the
deny.tomlfailure while adding this repo's gates to a local task runner. The.gitattributespath turned up in the same pass.