fix(scripts): make fetch-profile-repos.sh executable - #91
Open
nerdalytics wants to merge 1 commit into
Open
nerdalytics wants to merge 1 commit into
nerdalytics wants to merge 1 commit into
Conversation
The script has a bash shebang and 27 call sites across the docs and the cold-profile tests invoke it as ./scripts/fetch-profile-repos.sh, but git has carried it at mode 100644 since it was added in d8cc106. Every other script in scripts/ is 100755, so the documented command exits with permission denied. Signed-off-by: nerdalytics <97166791+nerdalytics@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
./scripts/fetch-profile-repos.shexits with permission denied. The file has been mode 100644 since d8cc106 added it on 2026-08-19, so the command in the docs has never worked.Type of Change
Changes Made
scripts/fetch-profile-repos.sh. It is the only shell script in
scripts/at 100644, and the other five are 100755. It has a#!/usr/bin/env bashshebang, and 27 call sites invoke it as./scripts/fetch-profile-repos.sh.The 27 call sites:
tests/cold_profile_gates.rs(12, of which 8 are skip messages telling the reader to run it)example/README.md(3)docs/markdown-context.md(3)AGENTS.md(2)docs/internal/profile.md(2)docs/guides/markdown-context-graph.md(2)docs/agent-recipes.md,docs/internal/PR-check.md,rgctl-tests/README.md(1 each)Testing
On
main,./scripts/fetch-profile-repos.shgivespermission deniedandtest -xfails. On this branchtest -xpasses andbash -nreports no syntax error. I did not run the fetch itself, because it clones 14 repositories including torvalds/linux and llvm/llvm-project.cargo testTest environment:
Checklist
Breaking Changes
None. No workflow under
.github/workflows/runs this script, and the file content is unchanged.Additional Notes
The alternative is to rewrite the 27 call sites as
bash ./scripts/fetch-profile-repos.sh. One mode bit is the smaller change, and it matches the other five scripts.