Add support for overriding block element using blockStyleFn#113
Open
filipengberg wants to merge 2 commits intosstur:masterfrom
Open
Add support for overriding block element using blockStyleFn#113filipengberg wants to merge 2 commits intosstur:masterfrom
filipengberg wants to merge 2 commits intosstur:masterfrom
Conversation
added 2 commits
October 31, 2017 12:02
|
Hi @sstur, is there work needed to be done before this MR is merged? Really interested in this. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the possibility to override the rendered block element using
blockStyleFn. This functionality is currently supported ininlineStyleFnso seems fitting that it can be done inblockStyleFnas well.It is currently possible to override the block tag using a custom
blockRenderer. The problem is that using ablockRenderercauses the conversion to skiprenderBlockContentwhich does a lot of good stuff. When all you want is to modify the block element but keep the default blockRenderer, this functionality comes in handy!