InlineStyleFn adjustments - produce separated elements for each inline style#114
Open
denich wants to merge 3 commits intosstur:masterfrom
Open
InlineStyleFn adjustments - produce separated elements for each inline style#114denich wants to merge 3 commits intosstur:masterfrom
denich wants to merge 3 commits intosstur:masterfrom
Conversation
added 3 commits
November 1, 2017 13:20
|
This sounds like it'd fix #120 for me? |
Contributor
Author
|
@sontek Yea, looks like it should |
|
this isn't working with me inline styles the color to be specific |
|
Would love to see this merged in so I can fix an issue on one of my repos betancourtl/draft-js-custom-styles#2. -- Edit Actually this is not what I need, I just need to be able to apply multiple styles to an element. |
|
Would appreciate this being implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of
InlineStyleFn()accepts whole style set but can produce only one element. It leads to the troubles when you'll want to parse it back usingdraft-js-import-htmlbecause it can produce only one inline style per one element.Ex:
draft-js-export-htmldraft-js-import-html'scustomInlineFnbut it can produce only one style:The solution (implemented): generate separated element for each inline style (like it's done via
inlineStyles)Alternative solution: support returning
Style's array fromcustomInlineFnimport method