Add versioned JSON output to core commands - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--jsontostack check,stack fmt, andstack renderwhile preserving the existing human-readable outputContract
$schemaURL and rejects unknown fields or incoherent outcome/exit/error combinations--jsonretain their current stream and exit behaviorVerification
cargo fmt --all --checkcargo test --lockedcargo clippy --all-targets --all-features --locked -- -D warningsRUSTDOCFLAGS='-D warnings' cargo doc --no-deps --lockedpython3 scripts/generate_cli_assets.py --binary target/debug/stack --checknpm ci --ignore-scripts --no-auditnpm audit --audit-level=moderate(0 vulnerabilities)npm run test:cli-output-schema(7 fixtures and 3 compatibility tests)STACK_BINARY=target/debug/stack npm run test:consumer-prototypecargo llvm-cov --all-features --locked --fail-under-lines 90 --fail-under-functions 95 --fail-under-regions 90(90.74% lines, 96.92% functions, 91.45% regions)cargo audit(no known RustSec vulnerabilities)Ajv 8.20.0 is pinned as a development-only schema validator, installed without lifecycle scripts, and its MIT license is recorded with the other third-party licenses.