Add/Edit Bookmark Dialog by F3l1x1vo · Pull Request #278 · stackabletech/cockpit

F3l1x1vo · 2026-07-31T07:26:49Z

This PR adds a bookmark modal for adding and editing bookmarks. Currently, they are saved in localStorage (not a database like we hoped. The database is a v1 feature of the S3 Storage Browser and not yet available on the parent branch). Migrating these bookmarks to the database is an issue for later (#277).

The bookmarks are currently shown in a section on the dashboard but we will change the display of these as well (#271)

Closes #270

This reverts commit 740391c.

…ale images

* Add OPA client for admin rights checking - New OPA client module (src/lib/server/opa.ts) using plain fetch - Separate handleOpaAdmin middleware hook (fail-closed) - Admin status exposed to client via event.locals.isAdmin and $page.data - Prometheus metrics: opa_request_duration_seconds + opa_request_total - Helm chart for OPA 1.16.2 (dev/opa/) - Sample Rego policy with admin email domain check - Dev setup: alice is admin (alice@admin.example.com) - Configurable via STACKABLE_COCKPIT_OPA_ENABLED/URL/TIMEOUT env vars * Replace custom OPA fetch client with @open-policy-agent/opa SDK Uses OPAClient.evaluate() with fromResult callback instead of raw fetch. Same external interface (checkAdmin), same error handling (fail-closed). * fix YAML format * fix YAML format * fix YAML format * fix: handle bare boolean responses from OPA admin check The fromResult callback expected { admin: true } but OPA may return a bare boolean. Now handles both formats. * chore: remove merge artifact feature flags Remove unused archivePreviewMaxBytes and commented-out env vars (INFINITE_SCROLL, CUT_COPY, PASTE, RENAME, MOVE) that have no corresponding code. --------- Co-authored-by: F3l1x1vo <fli@ordix.de>

* #270 add bookmark dialog * add edit bookmarks dialog * fix cancel editing bookmark * fix darkmode for icons, cursor pointer over boxes * update product icons to use colored versions where possible * scaled icons down to 64x64 * Revert "scaled icons down to 64x64" This reverts commit 740391c. * revert image downscale, use svelte enhanced image component to downscale images * #271 overhaul dashboard layout design * fix unit test * Add OPA client for admin rights checking (#276) * Add OPA client for admin rights checking - New OPA client module (src/lib/server/opa.ts) using plain fetch - Separate handleOpaAdmin middleware hook (fail-closed) - Admin status exposed to client via event.locals.isAdmin and $page.data - Prometheus metrics: opa_request_duration_seconds + opa_request_total - Helm chart for OPA 1.16.2 (dev/opa/) - Sample Rego policy with admin email domain check - Dev setup: alice is admin (alice@admin.example.com) - Configurable via STACKABLE_COCKPIT_OPA_ENABLED/URL/TIMEOUT env vars * Replace custom OPA fetch client with @open-policy-agent/opa SDK Uses OPAClient.evaluate() with fromResult callback instead of raw fetch. Same external interface (checkAdmin), same error handling (fail-closed). * fix YAML format * fix YAML format * fix YAML format * fix: handle bare boolean responses from OPA admin check The fromResult callback expected { admin: true } but OPA may return a bare boolean. Now handles both formats. * chore: remove merge artifact feature flags Remove unused archivePreviewMaxBytes and commented-out env vars (INFINITE_SCROLL, CUT_COPY, PASTE, RENAME, MOVE) that have no corresponding code. --------- Co-authored-by: F3l1x1vo <fli@ordix.de> * chore: dedupe packages * #270 add admin check to pinning, add OPA tests * fix unit test * #270 show pin for all only to admins * fix unit test * pull from feat/app-bookmark-dialog * pull from feat/app-bookmark-dialog --------- Co-authored-by: dklOrdix <dkl@ordix.de>

… as tools inside the cockpit (#283) * #270 add bookmark dialog * add edit bookmarks dialog * fix cancel editing bookmark * fix darkmode for icons, cursor pointer over boxes * update product icons to use colored versions where possible * scaled icons down to 64x64 * Revert "scaled icons down to 64x64" This reverts commit 740391c. * revert image downscale, use svelte enhanced image component to downscale images * #275 allow users to pin bookmarks * #275 #280 add bookmarks to sidebar navigation, show external apps in cockpit * fix unit test * Add OPA client for admin rights checking (#276) * Add OPA client for admin rights checking - New OPA client module (src/lib/server/opa.ts) using plain fetch - Separate handleOpaAdmin middleware hook (fail-closed) - Admin status exposed to client via event.locals.isAdmin and $page.data - Prometheus metrics: opa_request_duration_seconds + opa_request_total - Helm chart for OPA 1.16.2 (dev/opa/) - Sample Rego policy with admin email domain check - Dev setup: alice is admin (alice@admin.example.com) - Configurable via STACKABLE_COCKPIT_OPA_ENABLED/URL/TIMEOUT env vars * Replace custom OPA fetch client with @open-policy-agent/opa SDK Uses OPAClient.evaluate() with fromResult callback instead of raw fetch. Same external interface (checkAdmin), same error handling (fail-closed). * fix YAML format * fix YAML format * fix YAML format * fix: handle bare boolean responses from OPA admin check The fromResult callback expected { admin: true } but OPA may return a bare boolean. Now handles both formats. * chore: remove merge artifact feature flags Remove unused archivePreviewMaxBytes and commented-out env vars (INFINITE_SCROLL, CUT_COPY, PASTE, RENAME, MOVE) that have no corresponding code. --------- Co-authored-by: F3l1x1vo <fli@ordix.de> * fix unit test * Add OPA client for admin rights checking (#276) * Add OPA client for admin rights checking - New OPA client module (src/lib/server/opa.ts) using plain fetch - Separate handleOpaAdmin middleware hook (fail-closed) - Admin status exposed to client via event.locals.isAdmin and $page.data - Prometheus metrics: opa_request_duration_seconds + opa_request_total - Helm chart for OPA 1.16.2 (dev/opa/) - Sample Rego policy with admin email domain check - Dev setup: alice is admin (alice@admin.example.com) - Configurable via STACKABLE_COCKPIT_OPA_ENABLED/URL/TIMEOUT env vars * Replace custom OPA fetch client with @open-policy-agent/opa SDK Uses OPAClient.evaluate() with fromResult callback instead of raw fetch. Same external interface (checkAdmin), same error handling (fail-closed). * fix YAML format * fix YAML format * fix YAML format * fix: handle bare boolean responses from OPA admin check The fromResult callback expected { admin: true } but OPA may return a bare boolean. Now handles both formats. * chore: remove merge artifact feature flags Remove unused archivePreviewMaxBytes and commented-out env vars (INFINITE_SCROLL, CUT_COPY, PASTE, RENAME, MOVE) that have no corresponding code. --------- Co-authored-by: F3l1x1vo <fli@ordix.de> * fix auth port, implement open in new tab option, fix custom link resolve * #270 add admin check to pinning, add OPA tests * fix unit test * #270 show pin for all only to admins * fix unit test * pull from feat/app-bookmark-dialog --------- Co-authored-by: dklOrdix <dkl@ordix.de>

# Conflicts: # TECH_DEBT.md # src/lib/server/auth.ts

stackable-cla · 2026-09-10T12:00:09Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ F3l1x1vo
❌ dklOrdix
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Bohreromir

Unless I do miss something the whole PinForEveryone does not work as its only stored in LocalStorage. Opa could then be removed too.

I havent yet read the whole thing, but I think this is enough for the meantime.

Feel free to ask for any clarifications.

Bohreromir · 2026-09-14T09:18:36Z

+      pinned,
+      // Only admins can set the "pin for everyone" flag; non-admins keep the
+      // existing value (e.g. when editing a bookmark pinned by an admin).
+      pinnedForEveryone: isAdmin ? pinnedForEveryone : (bookmark?.pinnedForEveryone ?? false)


Okay, I didn't knew that. So the way is forward is: merge this and s3-file-browser, then create a new pr in which its saved to the db?

Do we have an Issue for that?

F3l1x1vo · 2026-09-14T12:13:34Z

@Bohreromir #278 (comment)

I had hoped that the v1 PR (#208) would be merged already when this PR was ready for review. Thus we can either merge both and add a new issue or wait on the other PR to be merged since #275 speaks of a database being used. I would just wait on the other PR since this bookmark feature is not time sensitive.

Bohreromir

nearly done ;)

Bohreromir · 2026-09-14T14:51:49Z


 # OPA (Open Policy Agent) — admin rights checking
-# STACKABLE_COCKPIT_OPA_ENABLED=true           # Enable OPA admin checks (default: true)
+# STACKABLE_COCKPIT_OPA_ENABLED=true           # Enable OPA admin checks (default: false)


still does not line up. Env is set to true, comment here says false and the comment in src/lib/server/feature-flags.ts says false too. Its three places that need to line up

F3l1x1vo requested a review from dklOrdix July 31, 2026 07:26

F3l1x1vo self-assigned this Jul 31, 2026

F3l1x1vo changed the base branch from feat/iframe-modularization to main July 31, 2026 08:11

F3l1x1vo force-pushed the feat/app-bookmark-dialog branch from c622e28 to fbfa6e6 Compare July 31, 2026 08:17

F3l1x1vo and others added 14 commits September 2, 2026 07:23

#270 add bookmark dialog

e0fe691

add edit bookmarks dialog

80b1716

fix cancel editing bookmark

b866c48

fix darkmode for icons, cursor pointer over boxes

a663c17

update product icons to use colored versions where possible

52340e1

scaled icons down to 64x64

1f9f85e

Revert "scaled icons down to 64x64"

d93d2fe

This reverts commit 740391c.

revert image downscale, use svelte enhanced image component to downsc…

3684df3

…ale images

fix unit test

72426d6

#270 add admin check to pinning, add OPA tests

1ccbb04

fix unit test

a0e5f1c

#270 show pin for all only to admins

33bc633

fix unit test

7a7d76c

F3l1x1vo force-pushed the feat/app-bookmark-dialog branch from 286a34a to 7a7d76c Compare September 2, 2026 05:23

F3l1x1vo and others added 3 commits September 2, 2026 07:47

fix styling

dd9a256

F3l1x1vo mentioned this pull request Sep 3, 2026

Feat/iframe modularization #273

Closed

Merge remote-tracking branch 'origin/main' into feat/app-bookmark-dialog

a008a2b

# Conflicts: # TECH_DEBT.md # src/lib/server/auth.ts

#293 remove support for embedded external services

d022e4d

Bohreromir self-requested a review September 11, 2026 07:41

Bohreromir requested changes Sep 11, 2026

View reviewed changes

Bohreromir mentioned this pull request Sep 11, 2026

epic: First Release Cockpit #294

Open

16 tasks

#278 implement changes suggested in code review

87137fb

F3l1x1vo added 4 commits September 14, 2026 08:33

Merge branch 'main' into feat/app-bookmark-dialog

e88c3d1

#278 refactor comments

4d79ef9

#278 fix unit tests

6e1a6d0

#278 open bookmarks from dashboard as well

f8daddc

Bohreromir requested changes Sep 14, 2026

View reviewed changes

#278 implement changes suggested in code review

16532d4

Bohreromir reviewed Sep 14, 2026

View reviewed changes

#278 implement changes suggested in code review

011d9c9

F3l1x1vo added a commit that referenced this pull request Sep 16, 2026

#278 implement changes suggested in code review

c1ccfb0

F3l1x1vo added a commit that referenced this pull request Sep 17, 2026

#278 implement changes suggested in code review

cc43ef3

F3l1x1vo added a commit that referenced this pull request Sep 17, 2026

#278 strengthen e2e tests to be less flaky

b94619d

Uh oh!

Conversation

F3l1x1vo commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stackable-cla Bot commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bohreromir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bohreromir Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

F3l1x1vo commented Sep 14, 2026

Uh oh!

Bohreromir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bohreromir Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

F3l1x1vo commented Jul 31, 2026 •

edited

Loading

stackable-cla Bot commented Sep 10, 2026 •

edited

Loading