fix(zookeeper): Enable client certificate hostname verification - #1666
Closed
NickLarsenNZ wants to merge 1 commit into
Closed
NickLarsenNZ wants to merge 1 commit into
NickLarsenNZ wants to merge 1 commit into
Conversation
NickLarsenNZ
commented
Sep 21, 2026
| hunk to an unpatched tree: the fipsEnabled = true variant fails, the false variant | ||
| passes. | ||
|
|
||
| Remove this patch in future versions when it is fixed upstream. See ZOOKEEPER-XXXX |
Member
Author
There was a problem hiding this comment.
@lfrancke, I think we should raise an upstream issue for this.
Maybe there was some reason they don't want to use ZKTustManager (I don't understand why there is a split).
Member
Author
|
This is not actually the fix. Closing in favour of disabling client cert hostname validation for quorums, until ZOOKEEPER-5096 is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: Before ZK 3.9.6, there was no client certificate hostname validation in FIPS mode (default). Now there is, but it only seems to validate IPs, not hostnames.
This PR adds a patch to defers to the ZKTrustManager for client certificate hostname validation (which is already used by the non-FIPS path.
Warning
I'm unsure if doing this breaks some kind of FIPS contract.
I'm also unsure if there is some kind of toggle for SunJSSE implementation which does enable client certificate hostname validation. So far I don't think there is.
Before, with the enabled test in FIPS mode, we see it fail with: