Skip to content

feat!: Add PodSecurityContextBuilder::with_stackable_defaults#1205

Open
sbernauer wants to merge 1 commit intomainfrom
chore/security-context-stackable-defaults
Open

feat!: Add PodSecurityContextBuilder::with_stackable_defaults#1205
sbernauer wants to merge 1 commit intomainfrom
chore/security-context-stackable-defaults

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#645

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

/// It is recommended to use the [`PodSecurityContextBuilder::with_stackable_defaults`] instead
/// (if possible).
pub fn stackable_default_pod_security_context() -> PodSecurityContext {
todo!("Lars needs to define the exact settings he wants");
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A TODO for @lfrancke :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant