Skip retrieving listeners for pods that have a deletionTimestamp to avoid deadlock waiting for secret operator pvcs when the listeners have already been garbage collected - #755
Open
soenkeliebau wants to merge 3 commits into
Conversation
…void deadlock waiting for secret operator pvcs when the listeners have already been garbage collected. #720
Comment on lines
+243
to
+251
| let is_being_deleted = pod.metadata.deletion_timestamp.is_some(); | ||
| let pod_info = SchedulingPodInfo::from_pod( | ||
| &self.client, | ||
| &pod, | ||
| &selector.scope, | ||
| is_being_deleted, | ||
| ) | ||
| .await | ||
| .context(ParsePodSnafu)?; |
Member
There was a problem hiding this comment.
&pod is already given to from_pod as an argument. So I don't think there is a need to pass an extra argument.
The deletion_timestamp check can be done inside that function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #720
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker