fix(olm): support the 26.7.0 chart and registry layout - #129
Merged
Conversation
SDP 26.7.0 changed how the operator Helm charts reference registries, which broke OLM manifest generation in three ways: * Operator images moved under the "sdp" path on quay.io, so the digest lookup no longer resolved. Introduce QUAY_REPO for the repository prefix. Also add the trailing slash to the tag API URL, which quay now 308-redirects to. * The charts no longer define image.repository in values.yaml; it comes from a per-registry overlay instead. Without one the chart fails to render, and the new IMAGE_REPOSITORY env var (which tells the operator where to pull product images from) has no value. Pass values/quay.io.yaml so bundles reference quay.io throughout. * The product cluster role is now empty unless the OpenShift API is advertised, because its only remaining rule is the securitycontextconstraints grant. Pass --api-versions security.openshift.io/v1 and drop the Python patching of that rule. The charts gate it themselves, and some operators gate more than one cluster role this way (spark has three, opa has two) which the single-role patch silently missed. Also correct the module docstring, which documented a nonexistent --output-dir, and the secret/listener rejection message, which pointed at a deleted script. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDP 26.7.0 changed how the operator Helm charts reference registries, which
broke OLM manifest generation in three ways:
Operator images moved under the "sdp" path on quay.io, so the digest lookup
no longer resolved. Introduce QUAY_REPO for the repository prefix. Also add
the trailing slash to the tag API URL, which quay now 308-redirects to.
The charts no longer define image.repository in values.yaml; it comes from a
per-registry overlay instead. Without one the chart fails to render, and the
new IMAGE_REPOSITORY env var (which tells the operator where to pull product
images from) has no value. Pass values/quay.io.yaml so bundles reference
quay.io throughout.
The product cluster role is now empty unless the OpenShift API is advertised,
because its only remaining rule is the securitycontextconstraints grant.
Pass --api-versions security.openshift.io/v1 and drop the Python patching of
that rule. The charts gate it themselves, and some operators gate more than
one cluster role this way (spark has three, opa has two) which the single-role
patch silently missed.
Also correct the module docstring, which documented a nonexistent --output-dir,
and the secret/listener rejection message, which pointed at a deleted script.
Used for stackabletech/issues#874