Skip to content

Conversation

@elelaysh
Copy link
Contributor

@elelaysh elelaysh commented Jan 7, 2026

This PR builds upon #2025.

  • it provides an updated overcloud host image and containers based on RockyLinux 9.7;
  • cadvisor is updated to 0.54.1 to fix vulnerabitilities;
  • opensearch-dashboards is updated to 2.19.4 to fix vulnerabilities.

@elelaysh elelaysh requested a review from a team as a code owner January 7, 2026 09:01
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the overcloud host image and containers to use RockyLinux 9.7. The changes primarily involve updating version tags and repository configurations. I've identified a few areas for improvement. There's some duplicated logic for determining DOCA distribution strings across configuration files, which I've suggested refactoring for better maintainability. Additionally, I've flagged a potentially invalid CVE identifier in the Trivy allow-list which could impact security scanning.

Comment on lines 18 to 19
doca_distribution: "{% if stackhpc_pulp_doca_version is version('3.2.0', '>=') %}rhel9{% else %}rhel9_{{ stackhpc_pulp_repo_rocky_9_minor_version }}{% endif %}"
doca_version_lookup_var: "stackhpc_pulp_repo_doca_{{ stackhpc_pulp_doca_version | replace('.', '_') }}_{{ doca_distribution }}_version"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid duplicating logic for determining the DOCA distribution string in etc/kayobe/stackhpc.yml, you could define a reusable variable here and use it in both places. This improves maintainability by having a single source of truth.

I'll add another comment in etc/kayobe/stackhpc.yml showing how to use the new variable.

doca_distribution_path_part: "{% if stackhpc_pulp_doca_version is version('3.2.0', '>=') %}rhel9{% else %}rhel9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}{% endif %}"
doca_distribution: "{{ doca_distribution_path_part | replace('.', '_') }}"
doca_version_lookup_var: "stackhpc_pulp_repo_doca_{{ stackhpc_pulp_doca_version | replace('.', '_') }}_{{ doca_distribution }}_version"

@elelaysh
Copy link
Contributor Author

elelaysh commented Jan 7, 2026

@elelaysh
Copy link
Contributor Author

elelaysh commented Jan 7, 2026

Successful tempest OVS after upgrade

Ran: 334 tests in 1306.978 sec.
 - Success: 258
 - Skipped: 76
 - Expected failures: 0
 - Unexpected success: 0
 - Failures: 0

Manual inspection : ok

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undoing accidental approval, apologies

@elelaysh
Copy link
Contributor Author

All checks passed except zuul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants