-
Notifications
You must be signed in to change notification settings - Fork 23
RockyLinux 9.7 containers #2061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the overcloud host image and containers to use RockyLinux 9.7. The changes primarily involve updating version tags and repository configurations. I've identified a few areas for improvement. There's some duplicated logic for determining DOCA distribution strings across configuration files, which I've suggested refactoring for better maintainability. Additionally, I've flagged a potentially invalid CVE identifier in the Trivy allow-list which could impact security scanning.
etc/kayobe/ofed.yml
Outdated
| doca_distribution: "{% if stackhpc_pulp_doca_version is version('3.2.0', '>=') %}rhel9{% else %}rhel9_{{ stackhpc_pulp_repo_rocky_9_minor_version }}{% endif %}" | ||
| doca_version_lookup_var: "stackhpc_pulp_repo_doca_{{ stackhpc_pulp_doca_version | replace('.', '_') }}_{{ doca_distribution }}_version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid duplicating logic for determining the DOCA distribution string in etc/kayobe/stackhpc.yml, you could define a reusable variable here and use it in both places. This improves maintainability by having a single source of truth.
I'll add another comment in etc/kayobe/stackhpc.yml showing how to use the new variable.
doca_distribution_path_part: "{% if stackhpc_pulp_doca_version is version('3.2.0', '>=') %}rhel9{% else %}rhel9.{{ stackhpc_pulp_repo_rocky_9_minor_version }}{% endif %}"
doca_distribution: "{{ doca_distribution_path_part | replace('.', '_') }}"
doca_version_lookup_var: "stackhpc_pulp_repo_doca_{{ stackhpc_pulp_doca_version | replace('.', '_') }}_{{ doca_distribution }}_version"|
Successful tempest OVS after upgrade Manual inspection : ok |
Alex-Welsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undoing accidental approval, apologies
Alex still can't read the GitHub interface after 7 years
|
All checks passed except zuul. |
This PR builds upon #2025.