clean up old stackit client#1320
Open
aniruddha2000 wants to merge 3 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
Bot
added
do-not-merge/needs-kind
Contributor
|
/lgtm |
Contributor
|
/kind cleanup |
ske-prow
Bot
added
kind/cleanup
Member
|
yes i would love to see some tests for the new clients aswell, at least with a similar density of the current ones |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
What this PR does / why we need it:
This PR is a part of breaking down #1060 PR into smaller pieces, where we are having ccm using new stackit client.This PR is a part of breaking down #1060 PR into smaller pieces, where we are cleaning up old stackit client.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: