Skip to content

CSI compatibility mode#175

Open
ftl wants to merge 55 commits into
mainfrom
csi-compatibility-mode
Open

CSI compatibility mode#175
ftl wants to merge 55 commits into
mainfrom
csi-compatibility-mode

Conversation

@ftl

@ftl ftl commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
This change allows to deploy two separate instances of the STACKIT CSI driver, on in "normal" mode, and the second one in "compatibility" mode. This is part of the migration from cinder to the STACKIT CSI driver.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This change requires the enhancement stackitcloud/cloud-provider-stackit#161 to be available in the cloud-provider-stackit CSI driver plugin.

Breaking changes:

@ske-prow ske-prow Bot added the kind/enhancement Enhancement, improvement, extension label Jun 12, 2026
@ske-prow

ske-prow Bot commented Jun 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aniruddha2000 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ftl ftl marked this pull request as draft June 12, 2026 07:36
@ske-prow ske-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 12, 2026
@ftl ftl force-pushed the csi-compatibility-mode branch from 4fa0ce5 to c923b5d Compare June 17, 2026 07:28
@ftl ftl requested a review from maboehm June 19, 2026 08:26
@ftl

ftl commented Jun 19, 2026

Copy link
Copy Markdown
Author

/test pull-gardener-extension-provider-stackit-verify

1 similar comment
@ftl

ftl commented Jun 23, 2026

Copy link
Copy Markdown
Author

/test pull-gardener-extension-provider-stackit-verify

@ske-prow ske-prow Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2026
@ftl

ftl commented Jun 23, 2026

Copy link
Copy Markdown
Author

/test pull-gardener-extension-provider-stackit-verify

2 similar comments
@ftl

ftl commented Jun 24, 2026

Copy link
Copy Markdown
Author

/test pull-gardener-extension-provider-stackit-verify

@ftl

ftl commented Jun 24, 2026

Copy link
Copy Markdown
Author

/test pull-gardener-extension-provider-stackit-verify

@ftl ftl marked this pull request as ready for review June 24, 2026 11:39
@ske-prow ske-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2026
nschad
nschad requested changes Jun 25, 2026
View reviewed changes
Comment thread ...rnal/shoot-system-components/charts/stackit-blockstorage-csi-driver/templates/daemonset.yaml Outdated
Comment thread charts/internal/shoot-system-components/charts/stackit-blockstorage-csi-driver/values.yaml Outdated
Comment thread pkg/controller/controlplane/csi_compatibility.go Outdated
Comment thread pkg/controller/controlplane/csi_compatibility.go Outdated
@ftl

ftl commented Jun 25, 2026

Copy link
Copy Markdown
Author

/hold until stackitcloud/cloud-provider-stackit#161 is merged

@ske-prow ske-prow Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 25, 2026
dergeberl
dergeberl reviewed Jul 2, 2026
View reviewed changes
Comment thread ...s/stackit-blockstorage-csi-driver/templates/csi-snapshot-controller-poddisruptionbudget.yaml
Comment thread ...ntrolplane/charts/stackit-blockstorage-csi-driver/templates/csi-snapshot-controller-vpa.yaml
Comment thread ...ane/charts/stackit-blockstorage-csi-driver/templates/deployment-csi-snapshot-controller.yaml
Comment thread ...rnal/shoot-system-components/charts/stackit-blockstorage-csi-driver/templates/daemonset.yaml Outdated
Comment thread pkg/apis/stackit/v1alpha1/types_controlplane.go Outdated
ftl and others added 21 commits July 6, 2026 16:17
@ftl
fix the compatibility mode accessor
d15c800
@ftl
simplify test assertions
88c40ea
@ftl
extract helper methods and constants
7ece65f
@ftl
handle unset compatibility mode
ed07511
@ftl
go mod tidy
6116e66
@ftl
modernize
89bee29
@ftl
move the legacy-volume-creation flag to the seed control plane
e324f1f
@ftl
use a different healthz port in the second csi drive instance, also i…
f6cca4e 
…n the seed control plane
@ftl
fix typo
48bbe2f
@ftl
use a better prefix
3d9af01
@nschad @ftl
fix: deploy seed part in correct namespace; findImage by specific ver…
38c6ad3 
…sion

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad @ftl
make stackit-blockstorage-csi-driver (shoot) chart customizable for d…
2cbfc21 
…ifferent driverName

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad @ftl
make health-port of CSI livenessprobe configurable
e85d5cf 
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@nschad @ftl
only deploy snapshot-controller once
24f65b7 
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@ftl
use the correct namespace
5610a2d
@nschad @ftl
fix: deploy snapshotcontroller by default; but NOT if in compatibilit…
05ef572 
…y mode

Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
@ftl
check the liveness-probe healthz port
0804373
@ftl
check the csi drive name in COMPAT(BLOCK) mode
f78f764
@ftl
check that there is no snapshot controller deployed with the
9899a45 
compatibility driver
@ftl
create an integration test that checks if the compatibility related
af3c625 
ManagedResource CRs are deployed

# Conflicts:
#	go.mod
#	go.sum
@ftl
add test to cover the transition from compat to default
60a7f79
@ftl ftl force-pushed the csi-compatibility-mode branch from 5677f76 to 60a7f79 Compare July 6, 2026 14:19
@ske-prow ske-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2026
hasit97
hasit97 reviewed Jul 7, 2026
View reviewed changes
Comment thread ...rnal/shoot-system-components/charts/stackit-blockstorage-csi-driver/templates/daemonset.yaml
Comment thread pkg/controller/controlplane/csi_compatibility.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschad nschad nschad requested changes
@dergeberl dergeberl dergeberl left review comments
@hasit97 hasit97 hasit97 left review comments
@maboehm maboehm Awaiting requested review from maboehm

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ftl @nschad @dergeberl @hasit97