Generator: Update SDK /services/postgresflex#8450
Open
stackit-pipeline wants to merge 5 commits into
Open
Conversation
… bump version relates to STACKITSDK-468
Contributor
marceljk
reviewed
Jul 8, 2026
Comment on lines
+15
to
+17
| const ( | ||
| InstanceStateEmpty = "" | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| const ( | |
| InstanceStateEmpty = "" | |
| ) |
shouldn't be needed anymore
Comment on lines
+33
to
+45
| switch s.State { | ||
| default: | ||
| return true, s, fmt.Errorf("instance with id %s has unexpected status %s", instanceId, s.State) | ||
| case InstanceStateEmpty: | ||
| return false, nil, nil | ||
| case postgresflex.STATE_PROGRESSING: | ||
| return false, nil, nil | ||
| case postgresflex.STATE_READY: | ||
| instanceCreated = true | ||
| instanceGetResponse = s | ||
| case postgresflex.STATE_FAILURE: | ||
| return true, s, fmt.Errorf("create failed for instance with id %s", instanceId) | ||
| } |
Contributor
There was a problem hiding this comment.
I would suggest to write this a bit different.
It should check only for ready state and error state.
In case of ready it should behave like now. In case of an error state it should fail with an error, like in the FAILURE state.
In the default case, it should continue to wait and not thrown an error. This makes it more robust in case the API provides new states and is similar to the behavior of our WaiterHelper function
| if err == nil { | ||
| return true, instanceGetResponse, nil | ||
| } | ||
| oapiErr, ok := err.(*oapierror.GenericOpenAPIError) //nolint:errorlint //complaining that error.As should be used to catch wrapped errors, but this error should not be wrapped |
Contributor
There was a problem hiding this comment.
nitpick
Suggested change
| oapiErr, ok := err.(*oapierror.GenericOpenAPIError) //nolint:errorlint //complaining that error.As should be used to catch wrapped errors, but this error should not be wrapped | |
| var oapiErr *oapierror.GenericOpenAPIError | |
| ok := errors.As(err, &oapiErr) |
Comment on lines
+58
to
+60
| if oapiErr.StatusCode < 500 { | ||
| return true, instanceGetResponse, fmt.Errorf("users request after instance creation returned %d status code", oapiErr.StatusCode) | ||
| } |
Contributor
There was a problem hiding this comment.
should be probably changed to an explicit 423 check to continue to wait. In every other error code, we can probably assume that something went completely wrong.
Suggested change
| if oapiErr.StatusCode < 500 { | |
| return true, instanceGetResponse, fmt.Errorf("users request after instance creation returned %d status code", oapiErr.StatusCode) | |
| } | |
| if oapiErr.StatusCode != 423 { | |
| return true, instanceGetResponse, fmt.Errorf("users request after instance creation returned %d status code", oapiErr.StatusCode) | |
| } |
But need to double check this
| return handler | ||
| } | ||
|
|
||
| // DeleteUserWaitHandler will wait for delete |
Contributor
There was a problem hiding this comment.
For users there is also a create waiter needed because it's also asynchronus
marceljk
reviewed
Jul 8, 2026
| os.Exit(1) | ||
| } | ||
|
|
||
| fmt.Printf("Created user \"%s\" associated to instance \"%s\".\n", username, instanceResp.Name) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Printf("Created user \"%s\" associated to instance \"%s\".\n", username, instanceResp.Name) | |
| fmt.Printf("Created user %q associated to instance %q.\n", username, instanceResp.Name) |
marceljk
reviewed
Jul 8, 2026
| fmt.Fprintf(os.Stderr, "Error when waiting for PostgreSQL Flex user deletion: %v", err) | ||
| } | ||
|
|
||
| fmt.Printf("Deleted PostgreSQL Flex user \"%s\".\n", instanceId) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Printf("Deleted PostgreSQL Flex user \"%s\".\n", instanceId) | |
| fmt.Printf("Deleted PostgreSQL Flex user %q.\n", instanceId) |
marceljk
reviewed
Jul 8, 2026
| fmt.Fprintf(os.Stderr, "Error when waiting for PostgreSQL Flex instance deletion: %v", err) | ||
| } | ||
|
|
||
| fmt.Printf("Deleted PostgreSQL Flex instance \"%s\".\n", instanceId) |
Contributor
There was a problem hiding this comment.
Suggested change
| fmt.Printf("Deleted PostgreSQL Flex instance \"%s\".\n", instanceId) | |
| fmt.Printf("Deleted PostgreSQL Flex instance %q.\n", instanceId) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to STACKITSDK-468
Generated from GitHub run 28926724566
spec comparison: stackitcloud/stackit-api-specifications@9873a8f...72230b8