Skip to content

feat(sqlserver): migrate sqlserver resources to the v3 API#1572

Merged
marceljk merged 4 commits into
mainfrom
feat/STACKITTPR-731-migrate-sqlserverflex-to-v3-api
Jul 8, 2026
Merged

feat(sqlserver): migrate sqlserver resources to the v3 API#1572
marceljk merged 4 commits into
mainfrom
feat/STACKITTPR-731-migrate-sqlserverflex-to-v3-api

Conversation

@marceljk

@marceljk marceljk commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

relates to STACKITTPR-731

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner July 8, 2026 09:28
@marceljk marceljk force-pushed the feat/STACKITTPR-731-migrate-sqlserverflex-to-v3-api branch from 8ebcc86 to dbde872 Compare July 8, 2026 09:28
Comment thread stackit/internal/services/sqlserverflex/instance/datasource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/datasource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/datasource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/resource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/instance/resource.go Outdated
Comment thread stackit/internal/services/sqlserverflex/user/resource.go Outdated
@marceljk marceljk force-pushed the feat/STACKITTPR-731-migrate-sqlserverflex-to-v3-api branch from bbf7e69 to 83d5d24 Compare July 8, 2026 12:53
Comment thread stackit/internal/services/sqlserverflex/instance/datasource.go Outdated
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Merging this branch changes the coverage (2 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance 33.69% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/instance 33.80% (+7.23%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/user 27.14% (-2.41%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/utils 75.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/int32planmodifier 46.67% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/listplanmodifier 51.35% (-20.08%) 💀 💀
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/objectplanmodifier 31.82% (+31.82%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/resource.go 37.12% (ø) 1021 379 642
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/instance/datasource.go 0.00% (ø) 51 (-7) 0 51 (-7)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/instance/resource.go 37.64% (+6.91%) 449 (+78) 169 (+55) 280 (+23) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/user/datasource.go 31.94% (-2.84%) 72 (+3) 23 (-1) 49 (+4) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/user/resource.go 25.38% (-2.31%) 197 (+2) 50 (-4) 147 (+6) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/utils/util.go 75.00% (ø) 8 6 2
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/int32planmodifier/use_state_for_unknown_if.go 46.67% (ø) 30 14 16
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/listplanmodifier/use_state_for_unknown_if.go 46.67% (+46.67%) 30 (+30) 14 (+14) 16 (+16) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/objectplanmodifier/use_state_for_unknown_if.go 31.82% (+31.82%) 44 (+44) 14 (+14) 30 (+30) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/instance/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/sqlserverflex_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/sqlserverflex_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/user/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/user/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sqlserverflex/utils/util_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/int32planmodifier/use_state_for_unknown_if_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/listplanmodifier/use_state_for_unknown_if_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/planmodifiers/objectplanmodifier/use_state_for_unknown_if_test.go

@marceljk marceljk merged commit 4fba22d into main Jul 8, 2026
3 checks passed
@marceljk marceljk deleted the feat/STACKITTPR-731-migrate-sqlserverflex-to-v3-api branch July 8, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants