Add StatusReporter abstraction for vMCP runtime #3159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement StatusReporter interface and LoggingReporter to enable vMCP runtime to report operational status (phase, discovered backends, health conditions). This commit provides: - Reporter interface with ReportStatus() and Start() methods - Status model: Phase, Conditions, DiscoveredBackends - LoggingReporter: Logs status updates for debugging (no persistence) - Integration into vMCP server lifecycle with shutdown function pattern The interface is designed to support future implementations that persist status to different backends. This PR includes only the logging implementation for CLI mode. Integration: - vMCP server calls reporter.Start() which returns shutdown function - CLI mode uses LoggingReporter with logging disabled by default - Status reporting is optional (nil reporter = disabled) Related: stacklok#3147 Signed-off-by: 4t8dd <wanger.xyz@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3159 +/- ##
=======================================
Coverage 57.15% 57.15%
=======================================
Files 341 342 +1
Lines 34055 34089 +34
=======================================
+ Hits 19463 19485 +22
- Misses 12984 12994 +10
- Partials 1608 1610 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@JAORMX can you take some time to review this PR so that I can keep working this serials. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement StatusReporter interface and LoggingReporter to enable vMCP runtime to report operational status (phase, discovered backends, health conditions).
This commit provides:
The interface is designed to support future implementations that persist status to different backends. This PR includes only the logging implementation for CLI mode.
Integration:
Related: #3147