Add thv status command for detailed workload info #3161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a new status command that displays comprehensive information about a specific MCP server workload, including resource usage metrics. Features: - Display workload details: name, status, health context, uptime, group, transport, URL, port, PID, CPU usage, and memory usage - Support both text (key-value) and JSON output formats (--format flag) - Add GetWorkloadStats to Runtime interface for CPU/memory metrics - Add StartedAt and ProcessID fields to core.Workload for uptime/PID tracking Components affected: - cmd/thv/app: New status command and tests - pkg/container/docker: GetWorkloadStats implementation with CPU calculation - pkg/container/kubernetes: GetWorkloadStats stub - pkg/container/runtime: WorkloadStats struct and interface updates - pkg/core: Workload struct extended with StartedAt, ProcessID - pkg/workloads: Manager interface and file_status updates - test/e2e: Status command integration tests Closes stacklok#3053 Signed-off-by: carlos <21148423+carlos-gn@users.noreply.github.com>
9 tasks
github-actions
bot
added
size/L
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3161 +/- ##
=======================================
Coverage 57.07% 57.08%
=======================================
Files 348 348
Lines 34608 34641 +33
=======================================
+ Hits 19753 19775 +22
- Misses 13207 13218 +11
Partials 1648 1648 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/L
Signed-off-by: carlos <21148423+carlos-gn@users.noreply.github.com>
carlos-gn
force-pushed
the
feat/status-command
branch
from
3e2a8ba to
d869b45
Compare
github-actions
bot
added
size/L
carlos-gn
force-pushed
the
feat/status-command
branch
from
f1c30dd to
c1fad6e
Compare
github-actions
bot
added
size/XL
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
carlos-gn
force-pushed
the
feat/status-command
branch
from
c1fad6e to
d869b45
Compare
github-actions
bot
added
size/L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
thv status <workload-name>command to display detailed workload information--formatflagGetWorkloadStatsto Runtime interface for CPU/memory metrics from container runtimeStartedAtandProcessIDfields tocore.Workloadfor uptime and PID trackingTest plan
Closes #3053