Fix race condition in testing #3239
Merged
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root Cause: The NewBackendWatcher() function was calling ctrl.SetLogger() on every invocation at line 109 in manager.go. Since tests run in parallel (using t.Parallel()), multiple goroutines were concurrently setting the global controller-runtime logger, causing a data race. Solution: Used sync.Once to ensure the controller-runtime logger is set exactly once across all invocations, even when multiple BackendWatcher instances are created concurrently.
ChrisJBurns
approved these changes
Jan 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3239 +/- ##
=======================================
Coverage 56.98% 56.99%
=======================================
Files 350 350
Lines 34938 34940 +2
=======================================
+ Hits 19909 19913 +4
+ Misses 13369 13367 -2
Partials 1660 1660 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause: The NewBackendWatcher() function was calling ctrl.SetLogger() on every invocation at line 109 in manager.go. Since tests run in parallel (using t.Parallel()), multiple goroutines were concurrently setting the global controller-runtime logger, causing a data race.
Solution: Used sync.Once to ensure the controller-runtime logger is set exactly once across all invocations, even when multiple BackendWatcher instances are created concurrently.