fix(aws-appsync): list caps, key ids and config cross-validation - #1370
Merged
Merged
Conversation
NitinKumar004
marked this pull request as ready for review
September 27, 2026 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Work item S0 from the AppSync build-out plan. It brings list paging, API key ids and config checks in line with real AppSync. All behaviour lives in the provider (
providers/aws/appsync).List caps
maxResultsat 25 with a minimum of 0. I checked each op in the botocore model and they all agree. The ops served today are ListGraphqlApis, ListDataSources and ListApiKeys.BadRequestExceptionwith the standard constraint message. A negative value is rejected the same way.API key ids
da2-plus 26 random lowercase alphanumeric characters. They used to be sequentialda2-%08x.Config cross-validation (create and update)
AMAZON_COGNITO_USER_POOLSneedsuserPoolConfig,OPENID_CONNECTneedsopenIDConnectConfigandAWS_LAMBDAneedslambdaAuthorizerConfig. The same rules apply to eachadditionalAuthenticationProvidersentry. A primary user pool config must havedefaultActionset to ALLOW or DENY, otherwise the call fails with "Invalid default effect type".serviceRoleArnis required for DynamoDB, Lambda, Elasticsearch, OpenSearch and EventBridge, and for HTTP when it signs with IAM.AMAZON_BEDROCK_RUNTIMEis now accepted as a type.Error wording
<Block> can't be null.pattern. I could not find a public capture of each one.Regression test
Not in this PR
Testing
go build ./..., then vet andgo test -raceon the touched packages. Lint with--new-from-rev=origin/developmentreports 0 issues.coveragegenoutput is unchanged.cloudemu serve: