fix(aws-eks): nodegroup scaling defaults and apply version updates when they settle - #1373
Merged
NitinKumar004 merged 1 commit intoSep 27, 2026
Conversation
NitinKumar004
marked this pull request as ready for review
September 27, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two EKS fixes (tracker rows EKS-X7 and EKS-X10).
EKS-X7: nodegroup scaling defaults and validation
CreateNodegroup without a
scalingConfigused to store 0/0/0, so the nodegroup had no nodes. Real EKS defaults to minSize 1, maxSize 2, desiredSize 2. The provider now applies that default, and with the node sync from desiredSize a default nodegroup brings up 2 Nodes.Validation now follows the API docs and the messages EKS returns:
Minimum capacity X can't be greater than desired size Y/desired capacity X can't be greater than max size YscalingConfigis an InvalidParameterExceptionscalingConfigis merged onto the current sizes inside the provider, under its lock, and the merged result is validated. The wire handler no longer does a Describe and merge itself.Driver change:
NodegroupConfig.ScalingConfigis now a pointer (nil means default), andNodegroupConfigUpdate.Scalingis a newNodegroupScalingUpdatewith optional sizes.EKS-X10: version updates apply when the update settles
With
--async-settle, UpdateClusterVersion changed the cluster version and the data plane's/versionright away, while the update was still in progress. Real EKS keeps reporting the old version until the update completes. Now:/versionswitches at the same moment. The data plane gets a newSetClusterVersionAt, which holds the current version until a given time on the caller's clock. Snapshots store the target version.InProgressin the response and in DescribeUpdate until the change settles, thenSuccessfulWith async settle off, all of this stays immediate as before.
Verification
nodegroup_scaling_test.go,version_settle_test.go,sdk_nodegroup_scaling_test.go, andTestServerVersion_ScheduledSwitch. Each fails on the old code.go build,go vet, andgo test -raceon providers/aws/eks, server/aws/eks, services/kubernetes and persist; golangci-lint with--new-from-revshows 0 issues.cloudemu serve --async-settlewith the aws CLI and kubectl: create-nodegroup with no scaling config gives min 1/max 2/desired 2 and 2 nodes inkubectl get nodes; a partial config is rejected. After update-cluster-version, describe-update is InProgress while describe-cluster shows 1.31 UPDATING andkubectl versionshows v1.31.x. Both switch to 1.32 once describe-update reads Successful. update-nodegroup-version behaves the same way.aws_eks_node_grouprequiresscaling_configin the provider, so it was tested with one: apply, plan clean, in-place cluster upgrade 1.31 to 1.32 with desired_size 2 to 3, plan clean, destroy.