fix(dashboard): read the include toggles and the enabled switch - #1430
Merged
Conversation
`includePackageJson`, `includeDependencyFiles` and `includeGitHubActions` were declared on the dashboard config, documented in the feature page's defaults table as `true`, shown in the example config, and read by nothing. Every ecosystem was always listed whatever the config said. `generateDashboard` now takes all three and filters the detected dependencies before the section is rendered, and `createOrUpdateDashboard` passes them through beside the `show*` toggles it already honoured. `enabled` was documented as defaulting to `false` and gated nothing. It is now honoured, but only as an explicit `false`. Enforcing the documented default literally would switch the dashboard off for every repository that never wrote a `dashboard` block — the same trap `ai.review.enabled` set in #1406, resolved the same way: unset means "not configured", never "off". The docs table now says so, since a documented default the code contradicts is what this whole series has been about. The switch is checked in the `dashboard` command and in the post-merge refresher, which are the two production paths that create or refresh the issue. The refresher reports it as a skip through the post-merge outcome rather than silently returning, so a maintainer who disabled the dashboard and configured `refreshDashboard` sees the two settings disagree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UWouahBJT3msK7V2VDYY6T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four dashboard keys, all declared, all documented with defaults, none read.
The three
include*togglesincludePackageJson,includeDependencyFiles,includeGitHubActions— in the feature page's defaults table astrue, in its example config, and consumed by nothing. Every ecosystem was always listed whatever the config said.generateDashboardnow takes all three and filters the detected dependencies before the section renders;createOrUpdateDashboardpasses them through beside theshow*toggles it already honoured. Each toggle drops exactly its own section — there's a test per toggle, and one for all three off.enabled— honoured as an explicitfalseonlyDocumented as defaulting to
false; gated nothing.Enforcing that default literally would switch the dashboard off for every repository that never wrote a
dashboardblock — the same trapai.review.enabledset in #1406, and resolved the same way: unset means "not configured", never "off." The docs table now reads:|
enabled|boolean|true| Set tofalseto stop the dashboard being created or refreshed |Checked in the two production paths that create or refresh the issue: the
dashboardcommand, and the post-merge refresher from #1425. The refresher reports it as a skip through the post-merge outcome rather than returning silently, so a maintainer who disabled the dashboard and configuredrefreshDashboardsees the two settings disagree.Tests
2148 → 2153.
Lint ✓ · typecheck ✓ ·
check:docs✓ · 0 fail🤖 Generated with Claude Code
https://claude.ai/code/session_01UWouahBJT3msK7V2VDYY6T