fix: evict expired entries from cursorIdentityCache#5
Open
iRonin wants to merge 1 commit into
Open
Conversation
The cache sets a 1-hour TTL but never removes expired entries, causing unbounded growth in long-lived Worker isolates when API keys are rotated. - Add lazy eviction on cache miss (delete expired entry when found) - Add periodic sweep on each set() to evict all other expired entries - Export evictExpiredCacheEntries and cursorIdentityCache for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cursorIdentityCacheis a plainMapwith a 1-hour TTL but never evicts expired entries. Keys that are looked up once and never again accumulate indefinitely. In long-lived Worker isolates (high-traffic deployments with rotating API keys), this causes unbounded memory growth.Fix
getCursorAccountIdentityfinds an expired entry, it deletes it immediatelyset(),evictExpiredCacheEntries()scans and removes all other expired entries — handles keys that are never looked up againFiles changed
worker/cursor.ts— eviction logic ingetCursorAccountIdentity+ newevictExpiredCacheEntries()worker/cursor.test.ts— 2 new tests for eviction behavior