fix: guard encodeVarint against out-of-range and non-integer inputs#6
Open
iRonin wants to merge 1 commit into
Open
fix: guard encodeVarint against out-of-range and non-integer inputs#6iRonin wants to merge 1 commit into
iRonin wants to merge 1 commit into
Conversation
encodeVarint silently truncated values >= 2^32 via '>>> 0', corrupting protobuf encoding. Add explicit guards that throw for: - Non-integer or negative values - Values >= 2^32 (exceeds 32-bit unsigned limit) This converts silent data corruption into a fail-loud error. Current field numbers are all < 256 so no behavior change for existing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
encodeVarint()usesvalue >>> 0to clamp input to 32-bit unsigned, silently truncating values ≥ 2³². If a protobuf tag ever exceeds this limit, the encoded message is corrupted without any error.Currently all field numbers are < 256 so this is not exploitable today, but it is a correctness bug in the encoding layer.
Fix
Add explicit guards:
This converts silent data corruption into a fail-loud error.
Files changed
worker/cursor.ts— validation guards inencodeVarint()worker/cursor.test.ts— test verifying normal usage still works