fix: return 400 for malformed JSON instead of 500#7
Open
iRonin wants to merge 1 commit into
Open
Conversation
parseJsonBody() did not wrap request.json(), so a SyntaxError from malformed JSON bubbled up as a 500 internal_error. Now catches the parse failure and throws a proper HttpError(400). - worker/http.ts: wrap request.json() in try/catch - worker/index.test.ts: test verifying 400 response for invalid JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parseJsonBody()inworker/http.tsvalidates Content-Type but does not wraprequest.json(). If the body contains malformed JSON,request.json()throws a rawSyntaxError, which bypassesHttpErrorhandling and renders as a 500internal_errorinstead of a 400.Fix
Wrap
request.json()in a try/catch that throwsHttpError("Invalid JSON in request body", 400).Files changed
worker/http.ts— try/catch aroundrequest.json()worker/index.test.ts— test asserting 400 for malformed JSON