Open
Conversation
Owner
|
Thanks for the contribution. In general, sending big commits like this one is frowned upon, and it’d be much better to send small commits that contain the minimum amount of changes to make the feature work you’re interested in. I’ll comment on the different parts specifically in a minute. |
Owner
There was a problem hiding this comment.
It seems like you’re mostly just changing the order here (and adding exported="true", not sure why that is necessary?). I suspect that the IDE you’re using has changed the file for you.
Is the additional DEPENDENCIES entry used for anything? If not, please revert the file entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This is my first real contribution to anything. I'm not sure if this is the right way of doing it.
Pretty much I loved the "idea" of your application but I was disappointed that it didn't have SharePoint support. No matter! I went ahead and added that in.
Thanks,
Pedro