Fix number ticker roll between values#27
Merged
Conversation
Glyph keys were derived from the character itself, so any digit change remounted that Digit and the strip replayed from 0 to the new value. Keys now come from place value (position from the right): a digit keeps its identity across updates and rolls the short way to the new number, and growing values add glyphs on the left without re-keying the rest. Stagger now only applies to the entrance reveal; live updates roll all digits immediately instead of trailing by index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes for NumberTicker when the value updates live:
Verification
bun run check green; roll behavior verified by hand in the ticker preview and the dynamic island timer.