Feature: new Aleph implementation - tests refactor#20
Open
JeremS wants to merge 1 commit intostarfederation:mainfrom
Open
Feature: new Aleph implementation - tests refactor#20JeremS wants to merge 1 commit intostarfederation:mainfrom
JeremS wants to merge 1 commit intostarfederation:mainfrom
Conversation
Fix: various docs Refactor: Reworked tests The common code for smoke tests and the persistent connection test are in their own namespaces now. They also have been refactored to be more REPL friendly. Chore: changelog and doc emphasis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a new implementation of the SDK for the Aleph. Beyond expanding the range of Ring adapter the SDK supports this works serves as an experiment how hard it is to implement the SDK protocols for new adapters.
This work also has lead to a refactor of some of the test code making it a bit more legible and REPL friendly.
Cheers,