Open
Conversation
starfishmod
requested changes
Jul 30, 2020
Owner
starfishmod
left a comment
starfishmod
left a comment
There was a problem hiding this comment.
Hey thanks! :)
I have added some suggestions to this before it should be merged
eastcoastcoder
commented
Jul 31, 2020
| if($pdetails['items']) { | ||
| $parameter['items']=$pdetails['items']; | ||
| }else if ($pdetails['properties']) { | ||
| $parameter['properties']=$pdetails['properties']['rendered']; |
Author
There was a problem hiding this comment.
Does this make sense to you? I see properties.raw and properties.rendered on some woocommerce endpoints. I just decided to keep the rendered as there appears to be more information. Works for my cases.
| 'properties'=> $prop['items']['properties'] | ||
| ); | ||
| if($prop['type']=='array' && !$prop['items']){ | ||
| $prop['items']=array('type'=>'string'); |
Author
There was a problem hiding this comment.
I noticed I was effectively assigning this property to itself...the property items are already set, they were just overriding themselves to string. This works as a fallback in this manner I believe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all array and object types defaulted to strings. This should instead look at the array/object item's type and (if the item is an object) all the properties within that item. I've tested it against two levels deep of arrays of objects and it seems to work correctly now.