Fix htole64 and le64toh missing on non-linux platforms#12
Conversation
| @@ -0,0 +1,112 @@ | |||
| #ifndef STARKWARE_CRYPTO_FFI_PORTABLE_ENDIAN_H_ | |||
There was a problem hiding this comment.
Did you strip the license header?
There was a problem hiding this comment.
Yes, I strip it from https://github.com/sahlberg/libsmb2/blob/master/include/portable-endian.h since author placed in public domain.
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @Solpatium)
src/starkware/crypto/ffi/utils.cc line 1 at r1 (raw file):
#include <endian.h>
This should be removed now, right?
Code quote:
#include <endian.h>|
Good catch, I missed it after the split from the initial PR. Sorry 😅 |
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Solpatium)
Split from #11