[6.x] Don't show unsaved changes warning when switching tabs#14678
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14676, introduced by #14592.
What
When switching tabs on an entry edit form, Statamic updates the URL hash (e.g.
/entries/1#tab-2) to remember the active tab. This adds entries to the browser history stack. Navigating back through those hash entries fires apopstateevent, which the listener added in #14592 was incorrectly treating as a full page navigation — showing the "unsaved changes" dialog even though the user never left the page.Fix
In the
popstatehandler, before showing the warning, compare the destination URL's pathname and search query against the dirty URL's. If only the hash differs (same path and query), the navigation is in-page tab switching — skip the warning and let the browser handle it normally.Also updated the existing tests to properly simulate the URL already being at the destination when
popstatefires (matching real browser behaviour), and added a test covering the hash-only case.