[6.x] Fix global variable references not resolving through the data repository#14938
Open
lazerg wants to merge 1 commit into
Open
[6.x] Fix global variable references not resolving through the data repository#14938lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
Contributor
|
Is this all it needs 😭 I've been unable to upgrade to Laravel 13 because of this, since I haven't been able to upgrade to v6... |
Contributor
Author
|
Yep, that's the whole fix. @jasonvarga mind taking a look when you get a chance - would be great to get this in so folks aren't blocked on the v6 upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global variable references use a
globals::prefix, but only the singularglobalrepository was registered, so the reference fell through and got tried against every repository including entries, which throws an invalid ID error on database drivers (for example when adding a set to a Replicator inside a global set). This registers theglobalsprefix against the global variables repository so the reference resolves correctly.Fixes statamic/eloquent-driver#537