[6.x] Pass the configured index name to the search insert job#14949
Open
ajnsn wants to merge 1 commit into
Open
[6.x] Pass the configured index name to the search insert job#14949ajnsn wants to merge 1 commit into
ajnsn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while back I added resolveNameUsing() for customising search index names (#10435). It's also in the docs: https://statamic.dev/frontend/search#customizing-index-names. I use it to prefix indexes per environment so staging and production don't collide on the same Algolia app.
Upgrading that same project to v6, indexing silently stopped, the index just stayed empty.
Since the insert job was moved to the queue (#13126), insertMultiple() rebuilds the index name for the job from the already-resolved name.
With a resolver set, that reconstructed name is wrong, so the job looks up an index that doesn't exist and fails on the queue.
update()has already cleared the index by then, so it just ends up empty - no error in sight.Imho the job should always get the index's own name so the resolver is reapplied when it re-resolves. So I store it and pass it through instead of reconstructing it. Added a test to the shared index tests.