Fix Site Defaults save failing with "axios is not defined"#623
Merged
Conversation
The save action referenced the bare global `axios`, which isn't defined in scope. Use the destructured `$axios` instance instead, matching the GET request in the same component. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where saving the Site Defaults configuration in the Control Panel failed with
ReferenceError: axios is not defined.This was happening because the save action in
ConfigureModal.vuereferenced the bare globalaxios, which isn't defined in the component's scope.This PR fixes it by using the
$axiosinstance already destructured from the app's global properties, matching how the GET request in the same component works.