refinements proposal for #342#355
Merged
martin-mfg merged 3 commits intoJul 12, 2026
Merged
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
Merged
Member
Good catch! |
6d656a5
into
stats-organization:fix-warnings
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(top-languages): default color when a language has no color
GitHub's
Language.coloris nullable, so a language can reach the card withcolor: null.The
compact,pie,donut, anddonut-verticallayouts validated the raw color and threw onnull,turning a normal request into a "Something went wrong" error card (previously such languages rendered gray).
refactor(core): restructure color validation
Cleans up
common/color.ts(no behavior change for valid inputs):isValidHexColor(x, numberSignPrefix)intoisBareHexColor/isPrefixedHexColor.Number.isFinite(rejectsInfinity)color.test.tsfor the two predicates + non-finite-angle cases.